On 4/23/19 5:42 AM, Jean-Francois Dagenais wrote:
On Apr 23, 2019, at 08:36, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
The call to thermal_cdev_update() causes any fan connected to the chip
to stop immediately. If the thermal subsystem is not set up to actually
handle the chip as cooling device, the remains stopped until is is
restarted manually with a write to a sysfs attribute.
There is evidence that thermal_cdev_update() should only be called from
thermal governors, not from thermal cooling device drivers. Drop the call.
Cc: Jean-Francois Dagenais <jeff.dagenais@xxxxxxxxx>
Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx>
Tested-by: Jean-Francois Dagenais <jeff.dagenais@xxxxxxxxx>
Thanks a lot!
I thought about merging the two patches, but then concluded that your
Tested-by: and the thoughts behind removing the call are valuable,
and decided to keep the patches separate after all.
Guenter
