> On Apr 23, 2019, at 08:36, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > The call to thermal_cdev_update() causes any fan connected to the chip > to stop immediately. If the thermal subsystem is not set up to actually > handle the chip as cooling device, the remains stopped until is is > restarted manually with a write to a sysfs attribute. > > There is evidence that thermal_cdev_update() should only be called from > thermal governors, not from thermal cooling device drivers. Drop the call. > > Cc: Jean-Francois Dagenais <jeff.dagenais@xxxxxxxxx> > Signed-off-by: Guenter Roeck <linux@xxxxxxxxxxxx> Tested-by: Jean-Francois Dagenais <jeff.dagenais@xxxxxxxxx> > > --- > drivers/hwmon/max6650.c | 2 -- > 1 file changed, 2 deletions(-) > > diff --git a/drivers/hwmon/max6650.c b/drivers/hwmon/max6650.c > index e977c2f2d74a..939953240827 100644 > --- a/drivers/hwmon/max6650.c > +++ b/drivers/hwmon/max6650.c > @@ -801,8 +801,6 @@ static int max6650_probe(struct i2c_client *client, > dev_warn(&client->dev, > "thermal cooling device register failed: %ld\n", > PTR_ERR(data->cooling_dev)); > - else > - thermal_cdev_update(data->cooling_dev); > #endif > return 0; > } > -- > 2.7.4 > I was just testing exactly this, and coming to the same conclusion and about to send a v6! ;) No need now.
