On Thu, Apr 18, 2019 at 04:39:35PM -0400, Jean-Francois Dagenais wrote: > > > > On Apr 18, 2019, at 16:12, Guenter Roeck <linux@xxxxxxxxxxxx> wrote: > > > > That explains why the other drivers don't generate an error message. > > You might want to reconsider the dev_err() above; it appears it adds zero > > value. > > > >> If I am wrong, then pwm-fan.c should also be visited since my max6650_probe code > >> was copy-pasted from it. > >> > > > > You are correct, that should not fail either. But two wrongs don't make it right. > > So you think any fan chip driver probe function in hwmon should succeed even if > (devm_)thermal_of_cooling_device_register fails?. Mmmh... perhaps I am missing > something, but I tend to disagree. That means that for example my system boots > normally without any errors, yet the thermal-zone I defined, which is there to > prevent my system from burning out, would remain incomplete (without required > cooling device) and yet no errors came out of the kernel. > > I just tested it and that's exactly what's happening! Yikes. > You would still get a warning message. Better than failing to load the driver completely. On top of that, this used to work before. Plus, you said it only happens in severe situations, ie if the kernel is out of memory, and in thact case there would be a traceback. Sorry, I don't get your point. Guenter
