> On Apr 18, 2019, at 16:13, Guenter Roeck <linux@xxxxxxxxxxxx> wrote:
>
>> + if (IS_ERR(data->cooling_dev)) {
>> + err = PTR_ERR(data->cooling_dev);
>> + dev_err(&client->dev,
>> + "Failed to register as cooling device (%d)\n", err);
>
> As mentioned in my other mail, this message adds zero value. Please drop.
How does one distinguish the different failures which can occur within a probe
function then. I know it is only useful for system integrators while debugging
DTS for example. But I find my self always having to insert these kind of messages
at each "return" statements of a failing probe implementation. I just think it's
nice for developers which can use the info to quickly troubleshoot the problem.
I won't fight this though. You are maintainer of this subsys so...
>
>> + return err;
>
> Sorry, I won't accept this.
You mean, you won't accept v3, but a v4 without the dev_err?
Perhaps also, we should wait a v4 which would use your new devm_register... ?
