On 11/28/18 10:53 AM, Deucher, Alexander wrote:
I believe the attached patch should fix the issue.
There is also a power attribute which returns -EINVAL, plus if I remember correctly some voltage attributes. Guenter
Alex ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------ *From:* Philippe L <flip101@xxxxxxxxx> *Sent:* Wednesday, November 28, 2018 11:20:38 AM *To:* Deucher, Alexander; Koenig, Christian; Zhou, David(ChunMing) *Cc:* Guenter Roeck; linux-hwmon@xxxxxxxxxxxxxxx *Subject:* amdgpu creating fan attribute for integrated graphics Hello, I'm writing to you after discussing a fancontrol issue on the lm-sensors issue tracker. I have a AMD Ryzen 5 2400G APU (with integrated graphics). The amdgpu driver is loaded and also creates a fan1_input attribute. However there is no separate GPU fan, there is only the CPU (APU) fan which is controlled by the motherboard. The fan1_input also seems to give some invalid readouts. I have not yet reached the bottom of this investigation, but so far my conclusion is that this causes fancontrol to choke up. Specifically the comment by Guenter Roeck here https://github.com/lm-sensors/lm-sensors/issues/144#issuecomment-442165451 describes the findings regarding the amdgpu driver. I'm writing to notify you about this problem, perhaps there can be some improvement in the amdgpu driver. I'm not really knowledgeable to discuss the workings of these drivers but i can provide debug output if needed. Best regards, Philippe
