On Mon, May 21, 2018 at 11:01:58PM +0200, Andrew Lunn wrote: > > >>+#if IS_ENABLED(CONFIG_X86) > > >>+#include <asm/intel-family.h> > > >>+#else > > >>+#define INTEL_FAM6_HASWELL_X 0x3F > > >>+#define INTEL_FAM6_BROADWELL_X 0x4F > > >>+#define INTEL_FAM6_SKYLAKE_X 0x55 > > >>+#endif > > > > > >The entire code is very Intel specific. Why this #if instead of > > >making the driver dependent on X86 ? > > > > > > > This code will be running on ARM kernel at this moment with a purpose > > of monitoring remote x86 CPUs through PECI connection > > How about moving what you need from asm/intel-family.h into a header > file in include/linux/. Or move the entire header? > That might be another option. The one non-option is the #if IS_ENABLED() in the driver. Thanks, Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
