On Mon, Sep 19, 2016 at 01:14:49PM -0500, Timothy Pearson wrote: > On 09/18/2016 08:41 PM, Guenter Roeck wrote: > > On Sun, Sep 18, 2016 at 07:50:55PM -0500, Timothy Pearson wrote: > >> Add a basic driver for the MAX31785, focusing on the fan control > >> features but ignoring the temperature and voltage monitoring > >> features of the device. > >> > >> This driver supports all fan control modes and tachometer / PWM > >> readback where applicable. > >> > > Could you try using hwmon_device_register_with_info() as available in > > linux-next ? Hopefully that should reduce driver size (and give the new API > > some test coverage). > > Ordinarily I'd be willing to try this, but in this case I wouldn't be > able to test the module on real hardware; it's an embedded system and > uses the 4.7 kernel at the moment. Would you be OK with merging a fixed > version of this patch and I can throw together an untested variant using > hwmon_device_register_with_info() for future work? > After actually looking into the datasheet, I must admit that I don't understand why you did not model this as a PMBus driver. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
