On Mon, Sep 19, 2016 at 01:40:36PM -0500, Timothy Pearson wrote: > On 09/18/2016 08:41 PM, Guenter Roeck wrote: > >> +Sysfs entries > >> +------------- > >> + > >> +fan[1-6]_input RO fan tachometer speed in RPM > >> +fan[1-6]_fault RO fan experienced fault > >> +fan[1-6]_target RW desired fan speed in RPM > >> +fan[1-6]_control_mode RW desired control mode: rpm, pwm, or auto > > > > Please use pwm[]_enable (see API) > > > >> +pwm[1-6]_enable RW output enabled, 0=disabled, 1=enabled > > > > Per API: 0 = no fan speed control (full speed), 1 = manual fan speed control > > enabled (using pwm[1-*]), 2+: automatic fan speed control > > > >> +pwm[1-6] RW fan target duty cycle (0-255) > > This particular device has a per-output PWM disable bit. How should > this be handled? I don't want to globally enable outputs that are not > connector or may possibly be incorrectly connected depending on hardware > design. > Not sure I understand. pwm[1-6]_enable = 0 means no fan speed control. Do you mean the (full speed) comment ? Having said that, looking into the datasheet, I see that this is actually a PMBus device. Why don't you just write a PMBus extension driver for it ? AFAICS drivers/hwmon/pmbus/max34440.c would come pretty close and could possibly even be extended to support this chip. Guenter -- To unsubscribe from this list: send the line "unsubscribe linux-hwmon" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
