Re: [PATCH v5 2/4] spi: Switch to using is_acpi_device_node() in spi_dev_set_name()

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Thu, Apr 11, 2024 at 12:06 PM Charles Keepax
<ckeepax@xxxxxxxxxxxxxxxxxxxxx> wrote:
>
> Use the more modern is_acpi_device_node() rather than checking
> ACPI_COMPANION().

I don't think it's valuable on its own. There is no clear motivation
why to do that, I suggested it exactly in the conjunction of not
introducing two ways of fwnode type check. That said, you probably
want to elaborate the motivation in the commit message if you want to
keep it separate.

...

> +#include <linux/fwnode.h>

This header is not supposed to be included by the end users. property.h is.

-- 
With Best Regards,
Andy Shevchenko