On 3/21/24 12:10, Julien Panis wrote:
On 3/20/24 11:25, Bhargav Raviprakash wrote:
From: Nirmala Devi Mal Nadar <m.nirmaladevi@xxxxxxxx>
Add support for TPS65224 pinctrl and GPIOs to TPS6594 driver as they have
significant functional overlap.
TPS65224 PMIC has 6 GPIOS which can be configured as GPIO or other
dedicated device functions.
Signed-off-by: Nirmala Devi Mal Nadar <m.nirmaladevi@xxxxxxxx>
Signed-off-by: Bhargav Raviprakash <bhargav.r@xxxxxxxx>
Acked-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
With this patch, an issue is observed on am62a:
root@am62axx-evm:~# dmesg | grep tps
...
[ 12.122631] tps6594-pinctrl tps6594-pinctrl.2.auto: error -EINVAL: Couldn't register
gpio_regmap driver
[ 12.133216] tps6594-pinctrl: probe of tps6594-pinctrl.2.auto failed with error -22
Without this patch, the issue disappears. Do you observe
the same result with your am62p ?
Julien Panis
Hi Barghav.
I found the issue in your patch.
In probe function you handle TPS652254 and TPS6594 'switch' cases,
but you do not handle TPS6593 and LP8764 cases.
Since AM62A uses a TPS6593, it currently falls in the default case,
and as a result probe fails.
Please fix it for v5.
Julien Panis
