Re: [PATCH] gpio: cdev: sanitize the label before requesting the interrupt

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Fri, Mar 22, 2024 at 2:30 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> On Wed, Mar 20, 2024 at 01:59:44PM +0100, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > Let's replace all "/" with "-".
> >
>
> I actually prefer the ":" you originally suggested, as it more clearly
> indicates a tier separation, whereas a hyphen is commonly used for
> multi-word names. And as the hyphen is more commonly used the sanitized
> name is more likely to conflict.
>

Sounds good, will do.
> >
> > +     label = make_irq_label(le->label);
> > +     if (!label)
> > +             goto out_free_le;
> > +
>
> Need to set ret = -ENOMEM before the goto, else you will return 0.
>

Eek, right, thanks.

Bart