Re: [PATCH v5 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol protocol basic support

[Cristian Marussi <cristian.marussi@xxxxxxx>]

On Fri, Mar 15, 2024 at 12:31:51AM +0000, Peng Fan wrote:
> > Subject: Re: [PATCH v5 0/4] firmware: arm_scmi: Add SCMI v3.2 pincontrol
> > protocol basic support
> > 
> > On Thu, Mar 14, 2024 at 09:35:17PM +0800, Peng Fan (OSS) wrote:
> > > Since SCMI 3.2 Spec is released, and this patchset has got R-b/T-b, is
> > > it ok to land this patchset?
> > >
> > 
> > I'll have a look at this last version and a spin on my test setup.
> > 
> > ...but has this V5 change at all since the Reviewed-by tags due to the latest
> > spec changes ?
> 
> The tags are same as V4. I only did a rebase, no more changes.
> > 

Ok.

> > ...IOW does this V5 include the latest small bits spec-changes or those latest
> > gpio-related spec-changes are just not needed at the level of the Linux pinctrl
> > support as of now and can be added later on when a Linux gpio driver will be
> > built on top of this ?
> 
> In my current test, I no need the gpio related changes, so I would add that later
> if you are ok.
> 

I COULD have agreed with this, since AFAIK there is currently an effort to
add support for GPIO on top of SCMI Pinctrl BUT not in Linux, so no reason to
block this series for gpio-related missing features, that should only be additions
not breaking backward compatibility...

....BUT, I've just wrapped my head again around the latest public release
of v3.2 spec (which has gone through so many changes and additions that
I had lost track O_o) AND beside the above mentioned GPIO changes there
are indeed also BREAKING changes around the commands PINCTRL_SETTINGS_GET and
PINCTRL_SETTINGS_CONFIGURE (which were the old PINCTRL_CONFIG_GET/SET),
that now also get/set the selected function: so that, at the end the payload
itself of those commands/replies has also changed IN SIZE, so the driver needs
definitely to be updated (and whatever you use to test on the backend server too,
if you want to test this...)

I think these changes (which I forgot being there) were in since last month, so
already V4 was broken in these regards (which I have not looked at)

I'll leave some comments along the series and test all of this again next week...
...since too many things has changed and I want to re-verify all on my side.

Thanks,
Cristian