On Thu, Feb 08, 2024 at 09:27:04PM +0100, Krzysztof Kozlowski wrote: > The match function used in gpio_device_find() should not modify the > contents of passed opaque pointer, because such modification would not > be necessary for actual matching and it could lead to quite unreadable, > spaghetti code. IIRC I also asked Bart about this in his series where something similar was used. Good it's not only me who sees the benefits from this. FWIW, Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> -- With Best Regards, Andy Shevchenko
Re: [PATCH] gpio: constify opaque pointer in gpio_device_find() match function
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH] gpio: constify opaque pointer in gpio_device_find() match function
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Fri, 9 Feb 2024 16:07:09 +0200
- In-reply-to: <20240208202704.631203-1-krzysztof.kozlowski@linaro.org>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20240208202704.631203-1-krzysztof.kozlowski@linaro.org>
- References:
- [PATCH] gpio: constify opaque pointer in gpio_device_find() match function
- From: Krzysztof Kozlowski
- [PATCH] gpio: constify opaque pointer in gpio_device_find() match function
- Prev by Date: Re: [PATCH v3 19/24] gpio: remove unnecessary checks from gpiod_to_chip()
- Next by Date: [PATCH v5 03/13] dt-bindings: clock: mobileye,eyeq5-clk: add bindings
- Previous by thread: Re: [PATCH] gpio: constify opaque pointer in gpio_device_find() match function
- Next by thread: Re: [PATCH] gpio: constify opaque pointer in gpio_device_find() match function
- Index(es):
 |