On Fri, Jan 26, 2024 at 11:43 PM Bjorn Helgaas <helgaas@xxxxxxxxxx> wrote: > On Fri, Jan 26, 2024 at 03:36:55PM +0100, Thomas Richard wrote: ... > It'd be super nice to have them the same. Passing in a "probe" flag > works but seems a little harder to read in cdns_pcie_host_setup() and > you have to keep track of what it means in the callers. FWIW, in another patch with a similar approach I found it (the approach) a bit ugly and unmaintainable. I would suggest properly refactoring to create 2+ functions and use as needed. -- With Best Regards, Andy Shevchenko
Re: [PATCH v2 13/15] PCI: cadence: add resume support to cdns_pcie_host_setup()
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 13/15] PCI: cadence: add resume support to cdns_pcie_host_setup()
- From: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>
- Date: Fri, 26 Jan 2024 23:50:39 +0200
- In-reply-to: <20240126214336.GA453589@bhelgaas>
- References: <20240102-j7200-pcie-s2r-v2-13-8e4f7d228ec2@bootlin.com> <20240126214336.GA453589@bhelgaas>
- References:
- [PATCH v2 13/15] PCI: cadence: add resume support to cdns_pcie_host_setup()
- From: Thomas Richard
- Re: [PATCH v2 13/15] PCI: cadence: add resume support to cdns_pcie_host_setup()
- From: Bjorn Helgaas
- [PATCH v2 13/15] PCI: cadence: add resume support to cdns_pcie_host_setup()
- Prev by Date: Re: [PATCH v2 12/15] phy: cadence-torrent: add suspend and resume support
- Next by Date: Re: [PATCH v2 14/15] PCI: j721e: add reset GPIO to struct j721e_pcie
- Previous by thread: Re: [PATCH v2 13/15] PCI: cadence: add resume support to cdns_pcie_host_setup()
- Next by thread: Re: [PATCH v2 13/15] PCI: cadence: add resume support to cdns_pcie_host_setup()
- Index(es):
 |