Re: [PATCH v2 12/15] phy: cadence-torrent: add suspend and resume support

[Andy Shevchenko <andy.shevchenko@xxxxxxxxx>]

On Fri, Jan 26, 2024 at 4:38 PM Thomas Richard
<thomas.richard@xxxxxxxxxxx> wrote:
>
> Add suspend and resume support.
>
> The already_configured flag is cleared during suspend stage to force the

the suspend

> PHY initialization during the resume stage.

...

> +       if (!cdns_phy->already_configured)
> +               clk_disable_unprepare(cdns_phy->clk);
> +       else
> +               cdns_phy->already_configured = 0;

What's wrong with a positive check?
Why do you need unprepare clock?

-- 
With Best Regards,
Andy Shevchenko