Re: [PATCH v4 3/4] pinctrl: renesas: pinctrl-rzg2l: Add the missing port pins P19 to P28

["Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>]

On Fri, Jan 12, 2024 at 5:10 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
>
>
>
> > -----Original Message-----
> > From: Lad, Prabhakar <prabhakar.csengg@xxxxxxxxx>
> > Sent: Friday, January 12, 2024 5:06 PM
> > Subject: Re: [PATCH v4 3/4] pinctrl: renesas: pinctrl-rzg2l: Add the
> > missing port pins P19 to P28
> >
> > Hi Biju,
> >
> > Thank you for the review.
> >
> > On Fri, Jan 12, 2024 at 2:31 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx>
> > wrote:
> > >
> > >
> > > Hi Prabhakar,
> > >
> > > > -----Original Message-----
> > > > From: Prabhakar <prabhakar.csengg@xxxxxxxxx>
> > > > Sent: Friday, January 12, 2024 2:26 PM
> > > > Subject: [PATCH v4 3/4] pinctrl: renesas: pinctrl-rzg2l: Add the
> > > > missing port pins P19 to P28
> > > >
> > <snip>
> > > >
> > > > +/**
> > > > + * struct rzg2l_variable_pin_cfg - pin data cfg
> > > > + * @cfg: port pin configuration
> > > > + * @port: port number
> > > > + * @pin: port pin
> > > > + */
> > > > +struct rzg2l_variable_pin_cfg {
> > > > +     u32 cfg:20;
> > > > +     u8 port:5;
> > >
> > >  u32 ??
> > This is done based on the feedback provided previously by Geert [0].
> >
> > > > +     u8 pin:5;
> > >
> > >  u32 ??
> > >
> > ditto.
> >
>
> As per[0] suggestion is,
>
> As cfg only contains the lower bits (PIN_CFG_*), I think you can fit
> everything in a u32:
>
>     u32 cfg: 20;
>     u32 port: 5;
>     u32 pin: 3;
>
Ouch my bad, i'll send a v5 with this change.

Cheers,
Prabhakar