Re: [PATCH v4 3/4] pinctrl: renesas: pinctrl-rzg2l: Add the missing port pins P19 to P28

["Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>]

Hi Biju,

Thank you for the review.

On Fri, Jan 12, 2024 at 2:31 PM Biju Das <biju.das.jz@xxxxxxxxxxxxxx> wrote:
>
>
> Hi Prabhakar,
>
> > -----Original Message-----
> > From: Prabhakar <prabhakar.csengg@xxxxxxxxx>
> > Sent: Friday, January 12, 2024 2:26 PM
> > Subject: [PATCH v4 3/4] pinctrl: renesas: pinctrl-rzg2l: Add the missing
> > port pins P19 to P28
> >
<snip>
> >
> > +/**
> > + * struct rzg2l_variable_pin_cfg - pin data cfg
> > + * @cfg: port pin configuration
> > + * @port: port number
> > + * @pin: port pin
> > + */
> > +struct rzg2l_variable_pin_cfg {
> > +     u32 cfg:20;
> > +     u8 port:5;
>
>  u32 ??
This is done based on the feedback provided previously by Geert [0].

> > +     u8 pin:5;
>
>  u32 ??
>
ditto.

[0] https://patchwork.kernel.org/project/linux-renesas-soc/patch/20231201131551.201503-3-prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx/#25625118

Cheers,
Prabhakar