On Wed, Nov 01, 2023 at 11:34:58AM +0200, Andy Shevchenko wrote: > On Wed, Nov 01, 2023 at 08:35:20AM +0200, Mika Westerberg wrote: > > On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote: > > ... > > > > + case 1: /* Set default strength value in case none is given */ > > > > The comment is good but I think would it make sense to have constant for > > this instead? > > If so, it makes sense to get it via entire GPIO library, and not locally for > Intel stuff. That said, I prefer to do that separately. Do you agree? Yes, agree.
Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- From: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
- Date: Wed, 1 Nov 2023 12:44:06 +0200
- In-reply-to: <ZUIbwtXmmTCHO9lf@smile.fi.intel.com>
- References: <20231030155340.3468528-1-andriy.shevchenko@linux.intel.com> <20231101063520.GC17433@black.fi.intel.com> <ZUIbwtXmmTCHO9lf@smile.fi.intel.com>
- References:
- [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- From: Andy Shevchenko
- Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- From: Mika Westerberg
- Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- From: Andy Shevchenko
- [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- Prev by Date: Re: [PATCH V7 3/3] leds: Add support for UP board CPLD onboard LEDS
- Next by Date: Re: [RFC v5 5/5] dt-bindings: firmware: arm,scmi: Add support for pinctrl protocol
- Previous by thread: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- Next by thread: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- Index(es):
 |