On Wed, Nov 01, 2023 at 08:35:20AM +0200, Mika Westerberg wrote: > On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote: ... > > + case 1: /* Set default strength value in case none is given */ > > The comment is good but I think would it make sense to have constant for > this instead? If so, it makes sense to get it via entire GPIO library, and not locally for Intel stuff. That said, I prefer to do that separately. Do you agree? -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Wed, 1 Nov 2023 11:34:58 +0200
- In-reply-to: <20231101063520.GC17433@black.fi.intel.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20231030155340.3468528-1-andriy.shevchenko@linux.intel.com> <20231101063520.GC17433@black.fi.intel.com>
- Follow-Ups:
- Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- From: Mika Westerberg
- Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- References:
- [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- From: Andy Shevchenko
- Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- From: Mika Westerberg
- [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- Prev by Date: Re: [PATCH 1/2] gpio: realtek: Add GPIO support for RTD SoC variants
- Next by Date: Re: [PATCH V7 2/3] pinctrl: Add support pin control for UP board CPLD/FPGA
- Previous by thread: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- Next by thread: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- Index(es):
 |