On Tue, Oct 31, 2023 at 12:22:47PM +0200, Andy Shevchenko wrote: > On Mon, Oct 30, 2023 at 11:14:11PM +0200, Raag Jadav wrote: > > On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote: > > > iWhen ->pin_config_set() is called from the GPIO library (assumed > > > GpioIo() ACPI resource), the argument can be 1, when, for example, > > > PullDefault is provided. In such case we supply sane default in > > > the driver. Move that default assingment to a switch-case, so > > > it will be consolidated in one place. > > > > Looks good. > > Thank you for review. Can you give your Rb tag then? Since I'm not a maintainer, I'm not sure if I qualify. But anyway, here you go. Reviewed-by: Raag Jadav <raag.jadav@xxxxxxxxx>