On Mon, Oct 30, 2023 at 11:14:11PM +0200, Raag Jadav wrote: > On Mon, Oct 30, 2023 at 05:53:40PM +0200, Andy Shevchenko wrote: > > iWhen ->pin_config_set() is called from the GPIO library (assumed > > GpioIo() ACPI resource), the argument can be 1, when, for example, > > PullDefault is provided. In such case we supply sane default in > > the driver. Move that default assingment to a switch-case, so > > it will be consolidated in one place. > > Looks good. Thank you for review. Can you give your Rb tag then? > iWhen -> When I'll fix it locally. -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Tue, 31 Oct 2023 12:22:47 +0200
- In-reply-to: <ZUAcffriaEkNcRH_@black.fi.intel.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20231030155340.3468528-1-andriy.shevchenko@linux.intel.com> <ZUAcffriaEkNcRH_@black.fi.intel.com>
- Follow-Ups:
- References:
- Prev by Date: Re: [PATCH] pinctrl: stm32: Add check for devm_kcalloc
- Next by Date: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- Previous by thread: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- Next by thread: Re: [PATCH v1 1/1] pinctrl: tangier: Move default strength assignment to a switch-case
- Index(es):
 |