Re: [PATCH 1/2] gpio: vf610: mask the gpio irq in system suspend and support wakeup

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Tue, Oct 17, 2023 at 5:25 AM <haibo.chen@xxxxxxx> wrote:
>
> From: Haibo Chen <haibo.chen@xxxxxxx>
>
> Add flag IRQCHIP_MASK_ON_SUSPEND to make sure gpio irq is masked on
> suspend, if lack this flag, current irq arctitecture will not mask
> the irq, and these unmasked gpio irq will wrongly wakeup the system
> even they are not config as wakeup source.
>
> Also add flag IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND to make sure the gpio
> irq which is configed as wakeup source can work as expect.
>
> Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx>
> ---
>  drivers/gpio/gpio-vf610.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpio/gpio-vf610.c b/drivers/gpio/gpio-vf610.c
> index a89ae84a1fa0..77d5b8dd2bd5 100644
> --- a/drivers/gpio/gpio-vf610.c
> +++ b/drivers/gpio/gpio-vf610.c
> @@ -260,7 +260,8 @@ static const struct irq_chip vf610_irqchip = {
>         .irq_unmask = vf610_gpio_irq_unmask,
>         .irq_set_type = vf610_gpio_irq_set_type,
>         .irq_set_wake = vf610_gpio_irq_set_wake,
> -       .flags = IRQCHIP_IMMUTABLE,
> +       .flags = IRQCHIP_IMMUTABLE | IRQCHIP_MASK_ON_SUSPEND
> +                       | IRQCHIP_ENABLE_WAKEUP_ON_SUSPEND,
>         GPIOCHIP_IRQ_RESOURCE_HELPERS,
>  };
>
> --
> 2.34.1
>

Both patches look like fixes, can you add the Fixes: tags?

Bart