Re: [brgl:gpio/devel 48/62] drivers/pinctrl/pinctrl-st.c:1326:9: error: implicit declaration of function 'st_gpio_direction_input'; did you mean 'st_gpio_direction_output'?

[Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>]

On Fri, 13 Oct 2023 at 07:25, kernel test robot <lkp@xxxxxxxxx> wrote:
>
> tree:   https://git.kernel.org/pub/scm/linux/kernel/git/brgl/linux.git gpio/devel
> head:   78853aac42280ea9b48d7abc74b348463cf8588d
> commit: e1e2007b6bb0ba0e1bb89235ffde4c0330655c29 [48/62] pinctrl: st: drop the wrapper around pinctrl_gpio_direction_input()
> config: arm-randconfig-001-20231013 (https://download.01.org/0day-ci/archive/20231013/202310131321.jDp5kiph-lkp@xxxxxxxxx/config)
> compiler: arm-linux-gnueabi-gcc (GCC) 13.2.0
> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20231013/202310131321.jDp5kiph-lkp@xxxxxxxxx/reproduce)
>
> If you fix the issue in a separate patch/commit (i.e. not just a new version of
> the same patch/commit), kindly add following tags
> | Reported-by: kernel test robot <lkp@xxxxxxxxx>
> | Closes: https://lore.kernel.org/oe-kbuild-all/202310131321.jDp5kiph-lkp@xxxxxxxxx/
>
> All errors (new ones prefixed by >>):
>
>    drivers/pinctrl/pinctrl-st.c: In function 'st_gpio_irq_request_resources':
> >> drivers/pinctrl/pinctrl-st.c:1326:9: error: implicit declaration of function 'st_gpio_direction_input'; did you mean 'st_gpio_direction_output'? [-Werror=implicit-function-declaration]
>     1326 |         st_gpio_direction_input(gc, d->hwirq);
>          |         ^~~~~~~~~~~~~~~~~~~~~~~
>          |         st_gpio_direction_output
>    cc1: some warnings being treated as errors
>
>
> vim +1326 drivers/pinctrl/pinctrl-st.c
>
> 727b0f71a56de6 Srinivas Kandagatla 2014-01-16  1321
> e855fa9a65c407 Patrice Chotard     2017-03-16  1322  static int st_gpio_irq_request_resources(struct irq_data *d)
> e855fa9a65c407 Patrice Chotard     2017-03-16  1323  {
> e855fa9a65c407 Patrice Chotard     2017-03-16  1324     struct gpio_chip *gc = irq_data_get_irq_chip_data(d);
> e855fa9a65c407 Patrice Chotard     2017-03-16  1325
> e855fa9a65c407 Patrice Chotard     2017-03-16 @1326     st_gpio_direction_input(gc, d->hwirq);
> e855fa9a65c407 Patrice Chotard     2017-03-16  1327
> c36f8c06ebd0c4 Linus Walleij       2023-04-04  1328     return gpiochip_reqres_irq(gc, d->hwirq);
> e855fa9a65c407 Patrice Chotard     2017-03-16  1329  }
> e855fa9a65c407 Patrice Chotard     2017-03-16  1330
>
> :::::: The code at line 1326 was first introduced by commit
> :::::: e855fa9a65c40788b5069abb0d094537daa22e05 pinctrl: st: add irq_request/release_resources callbacks
>
> :::::: TO: Patrice Chotard <patrice.chotard@xxxxxx>
> :::::: CC: Linus Walleij <linus.walleij@xxxxxxxxxx>
>
> --
> 0-DAY CI Kernel Test Service
> https://github.com/intel/lkp-tests/wiki

Now fixed in the gpio/devel branch.

Bart