On Fri, Oct 06, 2023 at 01:26:41PM +0300, Mika Westerberg wrote: > On Fri, Oct 06, 2023 at 12:40:33PM +0300, Andy Shevchenko wrote: ... > > if (cfg == CHV_PADCTRL0_GPIOCFG_GPO) > > return !!(ctrl0 & CHV_PADCTRL0_GPIOTXSTATE); > > + > > Unrelated whitespace change. Will drop it. > Otherwise looks good, > Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> Thank you! -- With Best Regards, Andy Shevchenko
Re: [PATCH v1 2/2] pinctrl: cherryview: Simplify code with cleanup helpers
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v1 2/2] pinctrl: cherryview: Simplify code with cleanup helpers
- From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
- Date: Fri, 6 Oct 2023 13:32:43 +0300
- In-reply-to: <20231006102641.GZ3208943@black.fi.intel.com>
- Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo
- References: <20231006094033.3082468-1-andriy.shevchenko@linux.intel.com> <20231006094033.3082468-2-andriy.shevchenko@linux.intel.com> <20231006102641.GZ3208943@black.fi.intel.com>
- References:
- [PATCH v1 1/2] pinctrl: cherryview: Avoid duplicated I/O
- From: Andy Shevchenko
- [PATCH v1 2/2] pinctrl: cherryview: Simplify code with cleanup helpers
- From: Andy Shevchenko
- Re: [PATCH v1 2/2] pinctrl: cherryview: Simplify code with cleanup helpers
- From: Mika Westerberg
- [PATCH v1 1/2] pinctrl: cherryview: Avoid duplicated I/O
- Prev by Date: Re: [PATCH v1 1/2] pinctrl: cherryview: Avoid duplicated I/O
- Next by Date: Re: [PATCH v1 2/2] pinctrl: cherryview: Simplify code with cleanup helpers
- Previous by thread: Re: [PATCH v1 2/2] pinctrl: cherryview: Simplify code with cleanup helpers
- Next by thread: Re: [PATCH v1 2/2] pinctrl: cherryview: Simplify code with cleanup helpers
- Index(es):
 |