Re: [PATCH] pinctrl: renesas: pinctrl-rzg2l: Add validation of GPIO pin in rzg2l_gpio_request()

["Lad, Prabhakar" <prabhakar.csengg@xxxxxxxxx>]

Hi Claudiu,

Thank you for the review.

On Wed, Sep 6, 2023 at 9:12 AM claudiu beznea <claudiu.beznea@xxxxxxxxx> wrote:
>
> Hi, Prabhakar,
>
> On 9/5/23 15:56, Prabhakar wrote:
> > From: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> >
> > Validate the GPIO pin request in rzg2l_gpio_request() callback using
> > rzg2l_validate_gpio_pin() function. This stops any accidental usage
> > of GPIO pins which are not supported by the SoCs.
> >
> > Signed-off-by: Lad Prabhakar <prabhakar.mahadev-lad.rj@xxxxxxxxxxxxxx>
> > ---
> >  drivers/pinctrl/renesas/pinctrl-rzg2l.c | 6 ++++++
> >  1 file changed, 6 insertions(+)
> >
> > diff --git a/drivers/pinctrl/renesas/pinctrl-rzg2l.c b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > index 37cdfe4b04f9..4ad08a4b786a 100644
> > --- a/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > +++ b/drivers/pinctrl/renesas/pinctrl-rzg2l.c
> > @@ -795,12 +795,18 @@ static const struct pinconf_ops rzg2l_pinctrl_confops = {
> >  static int rzg2l_gpio_request(struct gpio_chip *chip, unsigned int offset)
> >  {
> >       struct rzg2l_pinctrl *pctrl = gpiochip_get_data(chip);
> > +     const struct pinctrl_pin_desc *pin = &pctrl->desc.pins[offset];
> > +     u64 *pin_data = pin->drv_data;
>
> Maybe move this down a bit to keep the reverse christmas tree order that
> the driver is using as pattern.
>
Sure, will do and send a v2.

> Other than this:
> Reviewed-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
> Tested-by: Claudiu Beznea <claudiu.beznea.uj@xxxxxxxxxxxxxx>
>
Thanks for testing.

Cheers,
Prabhakar