Re: [PATCH -next] gpio: max3191x: remove redundant of_match_ptr

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Tue, Aug 01, 2023 at 11:36:10AM +0800, Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use CONFIG_OF
> and of_match_ptr here, we remove them all.

of_match_ptr()

> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it.

Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Signed-off-by: Zhu Wang <wangzhu9@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-max3191x.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-max3191x.c b/drivers/gpio/gpio-max3191x.c
> index 161c4751c5f7..bbacc714632b 100644
> --- a/drivers/gpio/gpio-max3191x.c
> +++ b/drivers/gpio/gpio-max3191x.c
> @@ -457,7 +457,6 @@ static int __init max3191x_register_driver(struct spi_driver *sdrv)
>  	return spi_register_driver(sdrv);
>  }
>  
> -#ifdef CONFIG_OF
>  static const struct of_device_id max3191x_of_id[] = {
>  	{ .compatible = "maxim,max31910" },
>  	{ .compatible = "maxim,max31911" },
> @@ -468,7 +467,6 @@ static const struct of_device_id max3191x_of_id[] = {
>  	{ }
>  };
>  MODULE_DEVICE_TABLE(of, max3191x_of_id);
> -#endif
>  
>  static const struct spi_device_id max3191x_spi_id[] = {
>  	{ "max31910" },
> @@ -484,7 +482,7 @@ MODULE_DEVICE_TABLE(spi, max3191x_spi_id);
>  static struct spi_driver max3191x_driver = {
>  	.driver = {
>  		.name		= "max3191x",
> -		.of_match_table	= of_match_ptr(max3191x_of_id),
> +		.of_match_table	= max3191x_of_id,
>  	},
>  	.probe	  = max3191x_probe,
>  	.remove	  = max3191x_remove,
> -- 
> 2.17.1
> 

-- 
With Best Regards,
Andy Shevchenko