Re: [PATCH -next] gpio: lpc32xx: remove redundant CONFIG_OF and of_match_ptr

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>]

On Tue, Aug 01, 2023 at 11:35:47AM +0800, Zhu Wang wrote:
> The driver depends on CONFIG_OF, so it is not necessary to use
> CONFIG_OF and of_match_ptr here, so we remove them all.

of_match_ptr()

> Even for drivers that do not depend on CONFIG_OF, it's almost always
> better to leave out the of_match_ptr(), since the only thing it can
> possibly do is to save a few bytes of .text if a driver can be used both
> with and without it.

There are two mails with the same subject. Which one to consider?
This one is good (with commit message change
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>

> Signed-off-by: Zhu Wang <wangzhu9@xxxxxxxxxx>
> ---
>  drivers/gpio/gpio-lpc32xx.c | 4 +---
>  1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-lpc32xx.c b/drivers/gpio/gpio-lpc32xx.c
> index d2b65cfb336e..5ef8af824980 100644
> --- a/drivers/gpio/gpio-lpc32xx.c
> +++ b/drivers/gpio/gpio-lpc32xx.c
> @@ -525,17 +525,15 @@ static int lpc32xx_gpio_probe(struct platform_device *pdev)
>  	return 0;
>  }
>  
> -#ifdef CONFIG_OF
>  static const struct of_device_id lpc32xx_gpio_of_match[] = {
>  	{ .compatible = "nxp,lpc3220-gpio", },
>  	{ },
>  };
> -#endif
>  
>  static struct platform_driver lpc32xx_gpio_driver = {
>  	.driver		= {
>  		.name	= "lpc32xx-gpio",
> -		.of_match_table = of_match_ptr(lpc32xx_gpio_of_match),
> +		.of_match_table = lpc32xx_gpio_of_match,
>  	},
>  	.probe		= lpc32xx_gpio_probe,
>  };
> -- 
> 2.17.1
> 

-- 
With Best Regards,
Andy Shevchenko