> +int framer_pm_runtime_get(struct framer *framer)
> +{
> + int ret;
> +
> + if (!framer)
> + return 0;
Can framer be a NULL pointer? This sort of test often covers up
bugs. So either let it dereference the NULL pointer and opps, or
return -EINVAL.
Andrew
Re: [PATCH v2 20/28] net: wan: Add framer framework support
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 20/28] net: wan: Add framer framework support
- From: Andrew Lunn <andrew@xxxxxxx>
- Date: Tue, 1 Aug 2023 11:56:12 +0200
- In-reply-to: <20230726150225.483464-21-herve.codina@bootlin.com>
- References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-21-herve.codina@bootlin.com>
- Follow-Ups:
- Re: [PATCH v2 20/28] net: wan: Add framer framework support
- From: Herve Codina
- Re: [PATCH v2 20/28] net: wan: Add framer framework support
- References:
- [PATCH v2 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer
- From: Herve Codina
- [PATCH v2 20/28] net: wan: Add framer framework support
- From: Herve Codina
- [PATCH v2 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer
- Prev by Date: Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
- Next by Date: Re: [PATCH v2 21/28] dt-bindings: net: Add the Lantiq PEF2256 E1/T1/J1 framer
- Previous by thread: [PATCH v2 20/28] net: wan: Add framer framework support
- Next by thread: Re: [PATCH v2 20/28] net: wan: Add framer framework support
- Index(es):
 |