> +static inline void qmc_clrsetbits16(void __iomem *addr, u16 clr, u16 set)
> +{
> + qmc_write16(addr, (qmc_read16(addr) & ~clr) | set);
> +}
> +
Please don't use inline in .c files. Let the compiler decide.
Andrew
Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
- From: Andrew Lunn <andrew@xxxxxxx>
- Date: Tue, 1 Aug 2023 11:36:43 +0200
- In-reply-to: <20230726150225.483464-11-herve.codina@bootlin.com>
- References: <20230726150225.483464-1-herve.codina@bootlin.com> <20230726150225.483464-11-herve.codina@bootlin.com>
- Follow-Ups:
- Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
- From: Herve Codina
- Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
- References:
- [PATCH v2 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer
- From: Herve Codina
- [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
- From: Herve Codina
- [PATCH v2 00/28] Add support for QMC HDLC, framer infrastruture and PEF2256 framer
- Prev by Date: Re: [PATCH v2 08/28] soc: fsl: cpm1: qmc: Introduce available timeslots masks
- Next by Date: Re: [PATCH v2 20/28] net: wan: Add framer framework support
- Previous by thread: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
- Next by thread: Re: [PATCH v2 10/28] soc: fsl: cpm1: qmc: Introduce qmc_chan_setup_tsa*
- Index(es):
 |