Re: [PATCH v2 2/2] tools: tests: port tests to shunit2

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Wed, Jun 21, 2023 at 11:36 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> On Wed, Jun 21, 2023 at 10:48:35AM +0200, Bartosz Golaszewski wrote:
> > From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> >
> > +
> >  # Save the PID of coprocess - otherwise we won't be able to wait for it
> >  # once it exits as the COPROC_PID will be cleared.
> >  DUT_PID=""
> >
> > -# mappings from local name to system chip name, path, dev name
>
> Minor nit - I would keep the line above - only removing the -g comment.
>

I restored the line and applied the patches.

Bart

> > -# -g required for the associative arrays, cos BATS...
> > -declare -g -A GPIOSIM_CHIP_NAME
> > -declare -g -A GPIOSIM_CHIP_PATH
>
> Either way, for the series,
>
> Reviewed-by: Kent Gibson <warthog618@xxxxxxxxx>
>
> Cheers,
> Kent.