Re: [PATCH v2 2/2] tools: tests: port tests to shunit2

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Jun 21, 2023 at 10:48:35AM +0200, Bartosz Golaszewski wrote:
> From: Bartosz Golaszewski <bartosz.golaszewski@xxxxxxxxxx>
> 
> +
>  # Save the PID of coprocess - otherwise we won't be able to wait for it
>  # once it exits as the COPROC_PID will be cleared.
>  DUT_PID=""
>  
> -# mappings from local name to system chip name, path, dev name

Minor nit - I would keep the line above - only removing the -g comment.

> -# -g required for the associative arrays, cos BATS...
> -declare -g -A GPIOSIM_CHIP_NAME
> -declare -g -A GPIOSIM_CHIP_PATH

Either way, for the series, 

Reviewed-by: Kent Gibson <warthog618@xxxxxxxxx>

Cheers,
Kent.



[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux