Re: [libgpiod][PATCH 0/4] dedicated examples

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Wed, Jun 14, 2023 at 3:57 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> On Wed, Jun 14, 2023 at 03:26:54PM +0200, Bartosz Golaszewski wrote:
> > On Wed, Jun 14, 2023 at 3:21 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> > >
> > > On Wed, Jun 14, 2023 at 03:03:51PM +0200, Bartosz Golaszewski wrote:
> > > > >
> > > >
> > > > Great idea! I applied patches 1-3 with some tweaks (coding style, C++
> > > > comments, statify functions, put local functions into anonymous
> > > > namespaces for C++, apply black to python code etc. etc.).
> > > >
>
>
> Any opinions on where to go next?
> Other use cases to add - e.g. multi-line versions?

Sure, I don't see why not.

> Convert the tool examples to use case examples?  Or do you still want
> to distribute the binaries for those?

No, the examples are built but not installed. And yes, if you have the
time and will to convert them to something more useful, please do!

> Any functionality to add to libgpiod?
>

I don't think so at the moment. Do you see anything obvious? I know,
we spoke about putting the line resolver into libgpiod but I'm not
sure we really want it. At least in the core library anyway. The GLib
layer on top of libgpiod is a place that would be a good target for
such a functionality IMO.

Other than that, I think libgpiod now has everything it needs to cover
all use-cases for the uAPI.

Bart

>  Cheers,
>  Kent.