Re: [libgpiod][PATCH 0/4] dedicated examples

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Wed, Jun 14, 2023 at 3:21 PM Kent Gibson <warthog618@xxxxxxxxx> wrote:
>
> On Wed, Jun 14, 2023 at 03:03:51PM +0200, Bartosz Golaszewski wrote:
> > >
> >
> > Great idea! I applied patches 1-3 with some tweaks (coding style, C++
> > comments, statify functions, put local functions into anonymous
> > namespaces for C++, apply black to python code etc. etc.).
> >
>
> Ok.  Would've been nice to get review comments before having changes
> pulled straight in, but whatever.
>

No functional changes. I wanted to avoid bikeshedding over coding style etc.

> Requiring C style comments in C++ is just weird.
>
> > You can respin the rust patch separately.
> >
>
> And what would you like respun there?
>

I saw comments from Erik and though you'd need a v2 but as it's mostly
a matter of taste, I'll apply it as is.

Bart

> Cheers,
> Kent.