Re: [v3][libgpiod][PATCH 1/1] gpio-tools-test.bats: modify delays in toggle test

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jun 06, 2023 at 02:32:37PM +0200, Bartosz Golaszewski wrote:
> On Tue, Jun 6, 2023 at 5:43 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> >
> > On Mon, Jun 05, 2023 at 01:43:35PM -0700, joe.slater@xxxxxxxxxxxxx wrote:
> > > From: Joe Slater <joe.slater@xxxxxxxxxxxxx>
> > >
> 
> Patch looks fine but interestingly, I'm not seeing any improvement in
> terms of execution times. Is this to be expected?
> 

This patch, as it stands, doesn't address execution times, it addresses
the possibility of some delay throwing the test script and gpiomon out of
sync and making the test fail.  So making the test more robust.

The toggle rate of the test is slow to reduce the likelyhood of sync
loss.  With this change it should be possible to increase the toggle
rate and so reduce the test duration, without impacting test reliabilty,
but that has not been done (yet).  And even then it would only reduce
the run time by a second or so.

Cheers,
Kent.




[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux