Re: [PATCH v3] gpio: pisosr: Use devm_gpiochip_add_data() to simplify remove path

[Andrew Davis <afd@xxxxxx>]

On 5/15/23 1:34 PM, andy.shevchenko@xxxxxxxxx wrote:
> Mon, May 15, 2023 at 12:43:21PM -0500, Andrew Davis kirjoitti:
> > Use devm version of gpiochip add function to handle removal for us.
> >
> > While here update copyright and module author.
>
> ...
>
> > +static void pisosr_mutex_destroy(void *data)
> > +{
> > +	struct mutex *lock = data;
> > +
> > +	mutex_destroy(lock);
> > +}
>
> No need to cast void * explicitly.

No need sure, but I really think it looks cleaner to be
explicit with the types here. If you feel strongly I
can change it though.

Andrew

> static void pisosr_mutex_destroy(void *lock)
> {
> 	mutex_destroy(lock);
> }