Mon, May 15, 2023 at 12:43:21PM -0500, Andrew Davis kirjoitti: > Use devm version of gpiochip add function to handle removal for us. > > While here update copyright and module author. ... > +static void pisosr_mutex_destroy(void *data) > +{ > + struct mutex *lock = data; > + > + mutex_destroy(lock); > +} No need to cast void * explicitly. static void pisosr_mutex_destroy(void *lock) { mutex_destroy(lock); } -- With Best Regards, Andy Shevchenko