Re: [libgpiod,v1.6.x,0/3] build: fix compile issues against non-glibc

[Bartosz Golaszewski <brgl@xxxxxxxx>]

On Sat, Feb 25, 2023 at 4:08 AM Benjamin Li <benl@xxxxxxxxxxxx> wrote:
>
> Fix issues when building against a C library other than glibc, such as
> Android's Bionic libc. The basename() patch isn't needed on master.
>
> A commit with a sample Android.bp file that's working against Android 11 is
> included for informational purposes, which I don't expect Bartosz to pull.
>
> Benjamin Li (3):
>   tools: use getprogname() when available to remove dependency on glibc
>   core: add missing #include for basename()
>   build: add Android.bp to build within Android tree
>
>  Android.bp           | 126 +++++++++++++++++++++++++++++++++++++++++++
>  configure.ac         |   5 ++
>  lib/core.c           |   1 +
>  tools/gpiodetect.c   |   4 +-
>  tools/gpiofind.c     |   4 +-
>  tools/gpioget.c      |   4 +-
>  tools/gpioinfo.c     |   4 +-
>  tools/gpiomon.c      |   4 +-
>  tools/gpioset.c      |   4 +-
>  tools/tools-common.c |  12 +++--
>  tools/tools-common.h |   4 +-
>  11 files changed, 154 insertions(+), 18 deletions(-)
>  create mode 100644 Android.bp
>
> --
> 2.25.1
>

I applied patch 2/3 as it's a fix. For the rest of them - my goal for
the v1.6.x series is to not support it anymore, than is absolutely
necessary - that means no new features and android build looks like
one to me. Any chance you can carry this locally?

For v2.x I'm open to adding it but have a couple comments, see the
relevant email threads.

Bart