RE: [PATCH 2/5] dt-bindings: power: reset: Add RZ/V2M PWC Power OFF bindings

[Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>]

Hi Krzysztof,

Thanks for your feedback.

> From: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
> Sent: 15 December 2022 09:50
> To: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>;
> Subject: Re: [PATCH 2/5] dt-bindings: power: reset: Add RZ/V2M PWC Power
> OFF bindings
> 
> On 13/12/2022 23:43, Fabrizio Castro wrote:
> > Add dt-bindings document for the RZ/V2M PWC Power OFF driver.
> 
> Drop driver.
> 
> Subject: drop second, redundant "bindings".

Thanks

> 
> >
> > Signed-off-by: Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> > ---
> >  .../reset/renesas,rzv2m-pwc-poweroff.yaml     | 48 +++++++++++++++++++
> >  1 file changed, 48 insertions(+)
> >  create mode 100644
> Documentation/devicetree/bindings/power/reset/renesas,rzv2m-pwc-
> poweroff.yaml
> >
> > diff --git
> a/Documentation/devicetree/bindings/power/reset/renesas,rzv2m-pwc-
> poweroff.yaml
> b/Documentation/devicetree/bindings/power/reset/renesas,rzv2m-pwc-
> poweroff.yaml
> > new file mode 100644
> > index 000000000000..12456e3e93e6
> > --- /dev/null
> > +++ b/Documentation/devicetree/bindings/power/reset/renesas,rzv2m-pwc-
> poweroff.yaml
> > @@ -0,0 +1,48 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +
> > +title: Renesas RZ/V2M External Power Sequence Controller (PWC) Power
> OFF
> > +
> > +description: |+
> > +  The PWC IP found in the RZ/V2M family of chips comes with the below
> > +  capabilities
> > +    - external power supply on/off sequence generation
> > +    - on/off signal generation for the LPDDR4 core power supply (LPVDD)
> > +    - key input signals processing
> > +    - general-purpose output pins
> > +  This node uses syscon to map the registers relevant to Power OFF (the
> > +  register map is retrieved from the parent dt-node), and the node
> should be
> > +  represented as a sub node of a "syscon", "simple-mfd" node.
> > +
> > +maintainers:
> > +  - Fabrizio Castro <fabrizio.castro.jz@xxxxxxxxxxx>
> > +
> > +properties:
> > +  compatible:
> > +    items:
> > +      - enum:
> > +          - renesas,r9a09g011-pwc-poweroff # RZ/V2M
> > +          - renesas,r9a09g055-pwc-poweroff # RZ/V2MA
> > +      - const: renesas,rzv2m-pwc-poweroff
> > +
> > +  regmap:
> > +    $ref: /schemas/types.yaml#/definitions/phandle
> > +    description: |
> > +      Phandle to the register map node.
> 
> This also has to go.

It'll go

> 
> > +
> > +required:
> > +  - compatible
> > +  - regmap
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > +  - |
> > +    poweroff {
> > +            compatible = "renesas,r9a09g011-pwc-poweroff",
> 
> Use 4 spaces for example indentation.

Doh, I'll be more careful next time.

Thanks,
Fab

> 
> > +                         "renesas,rzv2m-pwc-poweroff";
> > +            regmap = <&regmapnode>;
> > +    };
> 
> Best regards,
> Krzysztof