RE: [PATCH 1/2] gpio: pca953x: avoid to use uninitialized value pinctrl

[Bough Chen <haibo.chen@xxxxxxx>]

> -----Original Message-----
> From: Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>
> Sent: 2022年12月12日 23:52
> To: Bough Chen <haibo.chen@xxxxxxx>
> Cc: linus.walleij@xxxxxxxxxx; brgl@xxxxxxxx; dl-linux-imx <linux-imx@xxxxxxx>;
> linux-gpio@xxxxxxxxxxxxxxx; martyn.welch@xxxxxxxxxxxxx
> Subject: Re: [PATCH 1/2] gpio: pca953x: avoid to use uninitialized value pinctrl
> 
> On Fri, Dec 09, 2022 at 03:50:39PM +0800, haibo.chen@xxxxxxx wrote:
> > From: Haibo Chen <haibo.chen@xxxxxxx>
> >
> > There is a variable pinctrl declared without initializer. And then has
> > the case (switch operation chose the default case) to directly use
> > this uninitialized value, this is not a safe behavior. So here
> > initialize the pinctrl as 0 to avoid this issue.
> > This is reported by Coverity.
> 
> I have sent a v2 of this series with additional cleanups.

Yes, I saw these patches, really thanks!

Best Regards
Haibo Chen
> 
> --
> With Best Regards,
> Andy Shevchenko
>