From: Haibo Chen <haibo.chen@xxxxxxx> There is a variable pinctrl declared without initializer. And then has the case (switch operation chose the default case) to directly use this uninitialized value, this is not a safe behavior. So here initialize the pinctrl as 0 to avoid this issue. This is reported by Coverity. Fixes: 13c5d4ce8060 ("gpio: pca953x: Add support for PCAL6534") Signed-off-by: Haibo Chen <haibo.chen@xxxxxxx> --- drivers/gpio/gpio-pca953x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-pca953x.c b/drivers/gpio/gpio-pca953x.c index a59d61cd44b2..c3dd5ceab421 100644 --- a/drivers/gpio/gpio-pca953x.c +++ b/drivers/gpio/gpio-pca953x.c @@ -453,7 +453,7 @@ static u8 pca953x_recalc_addr(struct pca953x_chip *chip, int reg, int off) static u8 pcal6534_recalc_addr(struct pca953x_chip *chip, int reg, int off) { int addr; - int pinctrl; + int pinctrl = 0; addr = (reg & PCAL_GPIO_MASK) * NBANK(chip); -- 2.34.1