Re: [PATCH 1/2] gpio: pca953x: avoid to use uninitialized value pinctrl

[Andy Shevchenko <andriy.shevchenko@xxxxxxxxx>]

On Fri, Dec 09, 2022 at 03:50:39PM +0800, haibo.chen@xxxxxxx wrote:
> From: Haibo Chen <haibo.chen@xxxxxxx>
> 
> There is a variable pinctrl declared without initializer. And then
> has the case (switch operation chose the default case) to directly
> use this uninitialized value, this is not a safe behavior. So here
> initialize the pinctrl as 0 to avoid this issue.

> This is reported by Coverity.

Nice, but we need this to be in align with the datasheet.
Can you please check what registers are there and what their layout is?

...

> -	int pinctrl;
> +	int pinctrl = 0;

If it will becomes a correct fix, I would rather see the default case in
the switch-case than this.

-- 
With Best Regards,
Andy Shevchenko