Re: [PATCH RFC v2 2/3] pinconf-generic: clarify pull up and pull down config values

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Nov 17, 2022 at 12:37:44PM +0200, Andy Shevchenko wrote:
> On Thu, Nov 17, 2022 at 10:30:37AM +0100, Linus Walleij wrote:
> > On Tue, Nov 15, 2022 at 6:54 PM Niyas Sait <niyas.sait@xxxxxxxxxx> wrote:
> > 
> > > PIN_CONFIG_BIAS_PULL_DOWN and PIN_CONFIG_BIAS_PULL_UP values can
> > > be custom or an SI unit such as ohms
> > >
> > > Signed-off-by: Niyas Sait <niyas.sait@xxxxxxxxxx>
> > 
> > This patch is good as-is so I just applied it. No need to resend with
> > the ACPI series.
> 
> Is it? I think it's visible that it has TAB vs. space issue...

To be more clear, the "such as ohms" have been indented with spaces, while
everything else with TABs. On top of that I would use proper capitalization
for unit, i.e. Ohms. But the latter is minor.

-- 
With Best Regards,
Andy Shevchenko





[Index of Archives]     [Linux SPI]     [Linux Kernel]     [Linux ARM (vger)]     [Linux ARM MSM]     [Linux Omap]     [Linux Arm]     [Linux Tegra]     [Fedora ARM]     [Linux for Samsung SOC]     [eCos]     [Linux Fastboot]     [Gcc Help]     [Git]     [DCCP]     [IETF Announce]     [Security]     [Linux MIPS]     [Yosemite Campsites]

  Powered by Linux