Re: [libgpiod v2][PATCH v4 0/5] tools: improvements for v2

[Kent Gibson <warthog618@xxxxxxxxx>]

On Mon, Nov 14, 2022 at 11:12:25PM +0800, Kent Gibson wrote:
> On Mon, Nov 14, 2022 at 03:26:38PM +0100, Bartosz Golaszewski wrote:
> > On Mon, Nov 14, 2022 at 5:01 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> > >
> > 
> > I played with the tools a bit and really like the way they look now. I
> > think they're ready to hop into master, I'll do some more testing and
> > they should be in this week. Just one last request from my side: would
> > you mind updating the TOOLS section of the README? I'm aware it's not
> > yet updated for v2 and I plan to do it soon but we could already start
> > with the tools examples. You can send an incremental patch on top of
> > this series.
> > 
> 
> Good point - I totally forgot about the README.
> I'll take a look at it.
> 

And while collecting examples for the README I find the interactive mode
tab completion is now broken. It seems I broke it when fixing the prompt
behaviour when called from a script.
And when fixing that I notice some other odd tab completion behaviour -
seems there are at least two separate bugs in in_line_buffer().
All things that gpio-tools-tests doesn't currently test for, so I
should extend the test coverage as well.

And gpiomon --unquoted aborts as I forgot to cut-and-paste the parser
handler - and forgot to add a test for it too.
So another fix and more tests to add.

I probably wont get that done for a day or two, so you might want to hold
off on merging - or I can always provide patches later.

I also note that interactive mode does not support quoted line names on
the interactive command line yet. Adding that is sure to be entertaining.
Do you want to wait for me to patch that, or add it to the TODO list?

Cheers,
Kent.