Re: [PATCH RFC 2/3] pinconf-generic: add pull up and pull down config with resistance

[Linus Walleij <linus.walleij@xxxxxxxxxx>]

Hi Niyas,

thanks for your patch!

On Thu, Nov 10, 2022 at 8:13 PM Niyas Sait <niyas.sait@xxxxxxxxxx> wrote:

> pin configuration types have been extended to include a pull up
> and pull down config with resistance in ohms.
>
> Signed-off-by: Niyas Sait <niyas.sait@xxxxxxxxxx>
(...)
>   * @PIN_CONFIG_BIAS_PULL_DOWN: the pin will be pulled down (usually with high
>   *     impedance to GROUND). If the argument is != 0 pull-down is enabled,
>   *     if it is 0, pull-down is total, i.e. the pin is connected to GROUND.
> + * @PIN_CONFIG_BIAS_PULL_DOWN_OHMS: the pin will be pulled down with value
> + *  passed as argument. The argument is in ohms.

Hmmmmm hmmmm.

When I designed this, I definitely intended for the argument to
PIN_CONFIG_BIAS_PULL_DOWN to be used for this, so I would just:

- Use PIN_CONFIG_BIAS_PULL_DOWN
- Augment the comment to say:
  "If the argument is != 0 pull-down is enabled, the value is interpreted by
  the driver and can be custom or an SI unit such as ohms".

Yours,
Linus Walleij