Re: [libgpiod v2][PATCH v3 4/5] tools: add gpiowatch

[Kent Gibson <warthog618@xxxxxxxxx>]

On Tue, Nov 08, 2022 at 04:00:08PM +0100, Bartosz Golaszewski wrote:
> On Tue, Oct 11, 2022 at 2:29 AM Kent Gibson <warthog618@xxxxxxxxx> wrote:
> >
> > Add a gpiowatch tool, based on gpiomon, to report line info change
> > events read from chip file descriptors.
> >
> > Inspired by the gpio-watch tool in the linux kernel, but with gpiomon
> > features such as custom formatted output, filtering events of
> > interest and exiting after a number of events, so more useful for
> > scripting.
> >
> > Default output is minimalist, so just time, event type and line id.
> > Full event details are available using the custom formatted output.
> >
> > Signed-off-by: Kent Gibson <warthog618@xxxxxxxxx>
> > ---
> >
> > Changes v2 -> v3:
> >    - Minimise the default output to more closely match gpiomon.
> >    - Add --format option for when more detail is required.
> >    - Add --num-events option to exit after a number of events.
> >    - Add --event option to report only specific event types.
> >    - Add --quiet option to not print events.
> >    - fix monotonic to realtime conversion on 32 bit platforms.
> >
> 
> Nice and clean, I don't have any issues other than the regular
> coding-style bikeshedding.
> 

Will be renamed to gpionotify for v5, ok?

> What happened to the idea we've been floating about creating a single,
> busyboxy executable with links rather than separate executables? Have
> we ever agreed on it?
> 

Yeah, last we spoke on it we agreed it was of dubious value and a low
priority, so I didn't go anywhere with it.  You've reconsidered?

Cheers,
Kent.