On Fri, Oct 14, 2022 at 12:00 AM Marek Vasut <marex@xxxxxxx> wrote:
> The driver currently performs register read-modify-write without locking
> in its irqchip part, this could lead to a race condition when configuring
> interrupt mode setting. Add the missing bgpio spinlock lock/unlock around
> the register read-modify-write.
>
> Reviewed-by: Linus Walleij <linus.walleij@xxxxxxxxxx>
> Reviewed-by: Marc Zyngier <maz@xxxxxxxxxx>
> Fixes: 07bd1a6cc7cbb ("MXC arch: Add gpio support for the whole platform")
> Signed-off-by: Marek Vasut <marex@xxxxxxx>
Unrelated, but Marek can you have a look at this MXC patch since
you're obviously working on the platform:
https://lore.kernel.org/linux-gpio/20221007152853.838136-1-shenwei.wang@xxxxxxx/
Yours,
Linus Walleij
Re: [PATCH v6 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v6 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock
- From: Linus Walleij <linus.walleij@xxxxxxxxxx>
- Date: Mon, 17 Oct 2022 12:23:17 +0200
- In-reply-to: <20221013215946.216184-1-marex@denx.de>
- References: <20221013215946.216184-1-marex@denx.de>
- Follow-Ups:
- References:
- [PATCH v6 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock
- From: Marek Vasut
- [PATCH v6 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock
- Prev by Date: Re: [PATCH v6 2/2] gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode
- Next by Date: Re: [PATCH] pinctrl: qcom: Avoid glitching lines when we first mux to output
- Previous by thread: Re: [PATCH v6 2/2] gpio: mxc: Always set GPIOs used as interrupt source to INPUT mode
- Next by thread: Re: [PATCH v6 1/2] gpio: mxc: Protect GPIO irqchip RMW with bgpio spinlock
- Index(es):
 |