Re: [PATCH 2/3] arm64: dts: qcom: msm8996: align TLMM pin configuration with DT schema

[Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>]

On 12/10/2022 14:32, konrad.dybcio@xxxxxxxxxxxxxx wrote:
> On 2022-10-12 17:15, Krzysztof Kozlowski wrote:
>> DT schema expects TLMM pin configuration nodes to be named with
>> '-state' suffix and their optional children with '-pins' suffix.
>>
>> Signed-off-by: Krzysztof Kozlowski <krzysztof.kozlowski@xxxxxxxxxx>
>> ---
>>  arch/arm64/boot/dts/qcom/apq8096-db820c.dts   |  96 ++++------
>>  arch/arm64/boot/dts/qcom/apq8096-ifc6640.dts  |  68 ++------
>>  .../dts/qcom/msm8996-sony-xperia-tone.dtsi    |  26 +--
>>  .../boot/dts/qcom/msm8996-xiaomi-common.dtsi  |  10 +-
>>  .../boot/dts/qcom/msm8996-xiaomi-gemini.dts   |   8 +-
>>  .../boot/dts/qcom/msm8996-xiaomi-natrium.dts  |   4 +-
>>  .../boot/dts/qcom/msm8996-xiaomi-scorpio.dts  |   8 +-
>>  arch/arm64/boot/dts/qcom/msm8996.dtsi         | 164 +++++++++---------
>>  8 files changed, 153 insertions(+), 231 deletions(-)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> index 5cdc7ac1a9c0..a3d1ff1aba8f 100644
>> --- a/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> +++ b/arch/arm64/boot/dts/qcom/apq8096-db820c.dts
>> @@ -422,82 +422,46 @@ &tlmm {
>>  		"NC", /* GPIO_148 */
>>  		"NC"; /* GPIO_149 */
>>
>> -	sdc2_cd_on: sdc2_cd_on {
>> -		mux {
>> -			pins = "gpio38";
>> -			function = "gpio";
>> -		};
>> -
>> -		config {
>> -			pins = "gpio38";
>> -			bias-pull-up;		/* pull up */
>> -			drive-strength = <16>;	/* 16 MA */
>> -		};
>> +	sdc2_cd_on: sdc2-cd-on-state {
>> +		pins = "gpio38";
>> +		function = "gpio";
>> +		bias-pull-up;
>> +		drive-strength = <16>;
> How about drive-strength before bias- properties? I think most DTs have 
> it like that.

Sure, I can move it.

> 
> Other than that,
> 
> Reviewed-by: Konrad Dybcio <konrad.dybcio@xxxxxxxxxxxxxx>


Best regards,
Krzysztof