On Wed, 05 Oct 2022 16:57:43 +0200, Martin ZaÅ¥oviÄ? wrote: > This patch documents the devicetree entry for enabling Wiegand > bus driver. The drivers that will use Wiegand bus driver shall > create a sub-node of the documented node. > > Signed-off-by: Martin ZaÅ¥oviÄ? <m.zatovic1@xxxxxxxxx> > --- > Hello again, > > this is the second round of RFC patches in an attempt to add Wiegand > driver to linux kernel. Thank you for all the issues you have pointed > out in the first round. I have tried to fix all of them and I have > also implemented a Wiegand bus driver, that is now used by the GPIO > driver itself - as suggested by Linus. > > Any advice you have for me regarding the patches will be appreciated! > > With regards, > Martin ZaÅ¥oviÄ? > --- > .../devicetree/bindings/bus/wiegand.yaml | 50 +++++++++++++++++++ > 1 file changed, 50 insertions(+) > create mode 100644 Documentation/devicetree/bindings/bus/wiegand.yaml > My bot found errors running 'make DT_CHECKER_FLAGS=-m dt_binding_check' on your patch (DT_CHECKER_FLAGS is new in v5.13): yamllint warnings/errors: dtschema/dtc warnings/errors: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/wiegand.example.dtb: wiegand: 'wiegand-gpio' does not match any of the regexes: 'pinctrl-[0-9]+' From schema: /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/wiegand.yaml /builds/robherring/dt-review-ci/linux/Documentation/devicetree/bindings/bus/wiegand.example.dtb: wiegand: wiegand-gpio: {'compatible': ['wiegand,wiegand-gpio'], 'pinctrl-names': ['default'], 'pinctrl-0': [[4294967295]], 'data-hi-gpios': [[4294967295, 7, 6]], 'data-lo-gpios': [[4294967295, 6, 6]]} is not of type 'array' From schema: /usr/local/lib/python3.10/dist-packages/dtschema/schemas/gpio/gpio-consumer.yaml Documentation/devicetree/bindings/bus/wiegand.example.dtb:0:0: /example-0/wiegand/wiegand-gpio: failed to match any schema with compatible: ['wiegand,wiegand-gpio'] doc reference errors (make refcheckdocs): See https://patchwork.ozlabs.org/patch/ This check can fail if there are any dependencies. The base for a patch series is generally the most recent rc1. If you already ran 'make dt_binding_check' and didn't see the above error(s), then make sure 'yamllint' is installed and dt-schema is up to date: pip3 install dtschema --upgrade Please check and re-submit.