Hi Jianqun, Thank you for the patch! Yet something to improve: [auto build test ERROR on rockchip/for-next] [also build test ERROR on linus/master v6.0-rc4 next-20220907] [If your patch is applied to the wrong git tree, kindly drop us a note. And when submitting patch, we suggest to use '--base' as documented in https://git-scm.com/docs/git-format-patch#_base_tree_information] url: https://github.com/intel-lab-lkp/linux/commits/Jianqun-Xu/gpio-rockchip-support-acpi/20220907-172920 base: https://git.kernel.org/pub/scm/linux/kernel/git/mmind/linux-rockchip.git for-next config: loongarch-buildonly-randconfig-r002-20220907 (https://download.01.org/0day-ci/archive/20220908/202209080711.fRu3ImWL-lkp@xxxxxxxxx/config) compiler: loongarch64-linux-gcc (GCC) 12.1.0 reproduce (this is a W=1 build): wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross chmod +x ~/bin/make.cross # https://github.com/intel-lab-lkp/linux/commit/6b62c564dce1d94e9256d98661e5a7ae396627fb git remote add linux-review https://github.com/intel-lab-lkp/linux git fetch --no-tags linux-review Jianqun-Xu/gpio-rockchip-support-acpi/20220907-172920 git checkout 6b62c564dce1d94e9256d98661e5a7ae396627fb # save the config file mkdir build_dir && cp config build_dir/.config COMPILER_INSTALL_PATH=$HOME/0day COMPILER=gcc-12.1.0 make.cross W=1 O=build_dir ARCH=loongarch SHELL=/bin/bash drivers/gpio/ If you fix the issue, kindly add following tag where applicable Reported-by: kernel test robot <lkp@xxxxxxxxx> All errors (new ones prefixed by >>): In file included from include/linux/build_bug.h:5, from include/linux/bits.h:22, from include/linux/ioport.h:13, from include/linux/acpi.h:12, from drivers/gpio/gpio-rockchip.c:9: drivers/gpio/gpio-rockchip.c: In function 'rockchip_gpio_of_get_bank_id': drivers/gpio/gpio-rockchip.c:666:27: error: passing argument 1 of 'is_of_node' from incompatible pointer type [-Werror=incompatible-pointer-types] 666 | if (is_of_node(dev->of_node)) { | ~~~^~~~~~~~~ | | | struct device_node * include/linux/compiler.h:58:52: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ drivers/gpio/gpio-rockchip.c:666:9: note: in expansion of macro 'if' 666 | if (is_of_node(dev->of_node)) { | ^~ In file included from include/linux/irqdomain.h:35, from include/linux/acpi.h:13: include/linux/of.h:155:59: note: expected 'const struct fwnode_handle *' but argument is of type 'struct device_node *' 155 | static inline bool is_of_node(const struct fwnode_handle *fwnode) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ drivers/gpio/gpio-rockchip.c:666:27: error: passing argument 1 of 'is_of_node' from incompatible pointer type [-Werror=incompatible-pointer-types] 666 | if (is_of_node(dev->of_node)) { | ~~~^~~~~~~~~ | | | struct device_node * include/linux/compiler.h:58:61: note: in definition of macro '__trace_if_var' 58 | #define __trace_if_var(cond) (__builtin_constant_p(cond) ? (cond) : __trace_if_value(cond)) | ^~~~ drivers/gpio/gpio-rockchip.c:666:9: note: in expansion of macro 'if' 666 | if (is_of_node(dev->of_node)) { | ^~ include/linux/of.h:155:59: note: expected 'const struct fwnode_handle *' but argument is of type 'struct device_node *' 155 | static inline bool is_of_node(const struct fwnode_handle *fwnode) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ drivers/gpio/gpio-rockchip.c:666:27: error: passing argument 1 of 'is_of_node' from incompatible pointer type [-Werror=incompatible-pointer-types] 666 | if (is_of_node(dev->of_node)) { | ~~~^~~~~~~~~ | | | struct device_node * include/linux/compiler.h:69:10: note: in definition of macro '__trace_if_value' 69 | (cond) ? \ | ^~~~ include/linux/compiler.h:56:28: note: in expansion of macro '__trace_if_var' 56 | #define if(cond, ...) if ( __trace_if_var( !!(cond , ## __VA_ARGS__) ) ) | ^~~~~~~~~~~~~~ drivers/gpio/gpio-rockchip.c:666:9: note: in expansion of macro 'if' 666 | if (is_of_node(dev->of_node)) { | ^~ include/linux/of.h:155:59: note: expected 'const struct fwnode_handle *' but argument is of type 'struct device_node *' 155 | static inline bool is_of_node(const struct fwnode_handle *fwnode) | ~~~~~~~~~~~~~~~~~~~~~~~~~~~~^~~~~~ drivers/gpio/gpio-rockchip.c: In function 'rockchip_gpio_probe': >> drivers/gpio/gpio-rockchip.c:882:46: error: unterminated argument list invoking macro "if" 882 | MODULE_DEVICE_TABLE(of, rockchip_gpio_match); | ^ >> drivers/gpio/gpio-rockchip.c:883: error: expected '(' at end of input drivers/gpio/gpio-rockchip.c:721:9: note: '-Wmisleading-indentation' is disabled from this point onwards, since column-tracking was disabled due to the size of the code/headers 721 | if (!is_acpi_node(dev_fwnode(dev)) { | ^~ drivers/gpio/gpio-rockchip.c:721:9: note: adding '-flarge-source-files' will allow for more column-tracking support, at the expense of compilation time and memory drivers/gpio/gpio-rockchip.c:721:9: error: expected declaration or statement at end of input drivers/gpio/gpio-rockchip.c:712:13: warning: unused variable 'ret' [-Wunused-variable] 712 | int ret; | ^~~ drivers/gpio/gpio-rockchip.c:710:35: warning: unused variable 'bank' [-Wunused-variable] 710 | struct rockchip_pin_bank *bank = NULL; | ^~~~ drivers/gpio/gpio-rockchip.c:709:29: warning: unused variable 'pctldev' [-Wunused-variable] 709 | struct pinctrl_dev *pctldev = NULL; | ^~~~~~~ drivers/gpio/gpio-rockchip.c: At top level: drivers/gpio/gpio-rockchip.c:706:12: warning: 'rockchip_gpio_probe' defined but not used [-Wunused-function] 706 | static int rockchip_gpio_probe(struct platform_device *pdev) | ^~~~~~~~~~~~~~~~~~~ drivers/gpio/gpio-rockchip.c:643:1: warning: 'rockchip_gpio_find_bank' defined but not used [-Wunused-function] 643 | rockchip_gpio_find_bank(struct pinctrl_dev *pctldev, int id) | ^~~~~~~~~~~~~~~~~~~~~~~ drivers/gpio/gpio-rockchip.c:628:13: warning: 'rockchip_gpio_get_ver' defined but not used [-Wunused-function] 628 | static void rockchip_gpio_get_ver(struct rockchip_pin_bank *bank) | ^~~~~~~~~~~~~~~~~~~~~ drivers/gpio/gpio-rockchip.c:584:12: warning: 'rockchip_gpiolib_register' defined but not used [-Wunused-function] 584 | static int rockchip_gpiolib_register(struct rockchip_pin_bank *bank) | ^~~~~~~~~~~~~~~~~~~~~~~~~ cc1: some warnings being treated as errors vim +/if +882 drivers/gpio/gpio-rockchip.c 936ee2675eee1f Jianqun Xu 2021-08-16 878 936ee2675eee1f Jianqun Xu 2021-08-16 879 MODULE_DESCRIPTION("Rockchip gpio driver"); 936ee2675eee1f Jianqun Xu 2021-08-16 880 MODULE_ALIAS("platform:rockchip-gpio"); 936ee2675eee1f Jianqun Xu 2021-08-16 881 MODULE_LICENSE("GPL v2"); 936ee2675eee1f Jianqun Xu 2021-08-16 @882 MODULE_DEVICE_TABLE(of, rockchip_gpio_match); -- 0-DAY CI Kernel Test Service https://01.org/lkp
Re: [PATCH v3 RESEND] gpio: rockchip: support acpi
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
- Subject: Re: [PATCH v3 RESEND] gpio: rockchip: support acpi
- From: kernel test robot <lkp@xxxxxxxxx>
- Date: Thu, 8 Sep 2022 07:52:52 +0800
- In-reply-to: <20220907092722.3333752-1-jay.xu@rock-chips.com>
- References: <20220907092722.3333752-1-jay.xu@rock-chips.com>
- References:
- [PATCH v3 RESEND] gpio: rockchip: support acpi
- From: Jianqun Xu
- [PATCH v3 RESEND] gpio: rockchip: support acpi
- Prev by Date: Re: [PATCH v1 1/1] pinctrl: wpcm450: Correct the fwnode_irq_get() return value check
- Next by Date: [brgl:gpio/for-current] BUILD SUCCESS 279c12df8d2efb28def9d037f288cbfb97c30fe2
- Previous by thread: Re: [PATCH v3 RESEND] gpio: rockchip: support acpi
- Next by thread: [PATCH -next v2 1/5] misc: microchip: pci1xxxx: fix error handling in gp_aux_bus_probe()
- Index(es):
 |