Hello,
On Mon, Sep 05, 2022 at 10:14:08PM +0300, Andy Shevchenko wrote:
> fwnode_irq_get() may return all possible signed values, such as Linux
> error code. Fix the code to handle this properly.
It would be good to note explicitly here what a return value of zero
means, i.e., as the documentation of of_irq_get says, "IRQ mapping
failure", and why it should result in skipping this IRQ.
> Fixes: a1d1e0e3d80a ("pinctrl: nuvoton: Add driver for WPCM450")
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/pinctrl/nuvoton/pinctrl-wpcm450.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> index 0dbeb91f0bf2..8193b92da403 100644
> --- a/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> +++ b/drivers/pinctrl/nuvoton/pinctrl-wpcm450.c
> @@ -1081,10 +1081,13 @@ static int wpcm450_gpio_register(struct platform_device *pdev,
>
> girq->num_parents = 0;
> for (i = 0; i < WPCM450_NUM_GPIO_IRQS; i++) {
> - int irq = fwnode_irq_get(child, i);
> + int irq;
>
> + irq = fwnode_irq_get(child, i);
(Unneccesary churn, but I'll allow it)
> if (irq < 0)
> break;
> + if (!irq)
> + continue;
Since irq == 0 seems to be an error condition, the following seems fine
to me, and simpler:
- if (irq < 0)
+ if (irq <= 0)
break;
Thanks,
Jonathan
Attachment:
signature.asc
Description: PGP signature
